ZD16445#6724
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Aug 24, 2023
Merged
Conversation
julek-wolfssl
force-pushed
the
zd/16445
branch
from
6ffca9d to
b771b6e
Compare
JacobBarthelmeh
requested changes
Aug 24, 2023
| union { | ||
| const byte* bp; | ||
| const wolfssl_word* wp; | ||
| } tpb, tpm; |
Contributor
There was a problem hiding this comment.
Would this type punning have unintended consequences for C++ builds of wolfSSL?
Member
Author
There was a problem hiding this comment.
I don't think so. We test building with c++ compilers in jenkins and github actions and both are happy with it.
JacobBarthelmeh
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLsuffix to specify a larger integer typemaxas it can shadow other definitions