Skip to content

additional sanity check with GetIntPositive #6739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SparkiDev merged 1 commit into from
Aug 30, 2023
Merged

additional sanity check with GetIntPositive #6739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion wolfcrypt/src/asn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3283,8 +3283,21 @@ static int GetIntPositive(mp_int* mpi, const byte* input, word32* inOutIdx,
if (ret != 0)
return ret;

if (((input[idx] & 0x80) == 0x80) && (input[idx - 1] != 0x00))
/* should not be hit but adding in an additional sanity check */
if (idx + length > maxIdx) {
return MP_INIT_E;
}

if ((input[idx] & 0x80) == 0x80) {
if (idx < 1) {
/* needs at least one byte for length value */
return MP_INIT_E;
}

if (input[idx - 1] != 0x00) {
return MP_INIT_E;
}
}

if (initNum) {
if (mp_init(mpi) != MP_OKAY)
Expand Down