Curve25519/Ed25519: align buffers#6750
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Sep 8, 2023
Merged
Conversation
SparkiDev
force-pushed
the
curve25519_thumb2_2
branch
4 times, most recently
from
f992de1 to
a911305
Compare
4 tasks
SparkiDev
force-pushed
the
curve25519_thumb2_2
branch
5 times, most recently
from
0dde5d4 to
d0d1f4d
Compare
|
Still 2 buffer overruns according to CodeSonar on this stream related to the same path. I re-ran CodeSonar on your branch (SparkiDev:curve25519_thumb2_2) and now CodeSonar flags the same problem originating in wc_Ed25519PrivateKeyDecode. SARIF for both remaining issues attached |
SparkiDev
force-pushed
the
curve25519_thumb2_2
branch
from
d0d1f4d to
2fd2908
Compare
Make data structures align buffers. Align buffers in functions. Add versions that don't use umaal
SparkiDev
force-pushed
the
curve25519_thumb2_2
branch
from
2fd2908 to
90467aa
Compare
Contributor
Author
|
Made an update to wc_Ed25519PrivateKeyDecode to fix CodeSonar issue. |
Clean bill of health! Warnings are gone. |
JacobBarthelmeh
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make data structures align buffers.
Align buffers in functions.
Testing
Tested ARMv7M.
Checklist