FIPS 140-3 Pilot Program Check-in#6751
Merged
JacobBarthelmeh merged 7 commits intowolfSSL:masterfrom Sep 6, 2023
Merged
Conversation
kaleb-himes
previously approved these changes
Sep 5, 2023
Contributor
kaleb-himes
left a comment
kaleb-himes
left a comment
There was a problem hiding this comment.
Logic remains in-tact, good sync. Thank you @ejohnstown
the AesCtrSetKey function for AES-CTR.
…_AesCtrSetKey(), and add (void)dir in implementation to silence -Wunused.
douzzer
previously approved these changes
Sep 6, 2023
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
LGTM. In combo with https://github.com/wolfSSL/fips/pull/228 at 9dea8271c0ce, this is now passing:
cross-aarch64-armasm-fips-140-3-dev-all-unittest-sanitizer
cross-armv7a-all-armasm-testsuite
cross-armv6zk-thumb-all-asm
cross-aarch64-all-armasm-unittest-sanitizer
clang-tidy-fips-140-3-dev-defaults
clang-tidy-fips-140-3-dev-all
fips-140-3-dev-optest-acvp-sp-asm-gcc-latest
fips-140-3-dev-all linuxkm-all-fips-140-3-dev-dyn-hash
sp-all-asm-smallstack-sanitizer-fips-140-3-dev
linuxkm-all-fips-140-3-dev-dyn-hash
check-file-modes
check-source-text
check-shell-scripts
check-configure
Contributor
|
One of the automated tests needs investigation. |
Contributor
|
retest this please |
JacobBarthelmeh
previously approved these changes
Sep 6, 2023
…k buffers before freeing them, and ForceZero() the Hmac, wc_Sha512, wc_Sha384, wc_Sha256, and wc_Sha224 structures at the end of their respective freeing routines. also, remove superseded ForceZero() calls in wc_HKDF_Expand(), wc_SSH_KDF(), and wc_HKDF_Extract().
douzzer
force-pushed
the
merge-fips-builds
branch
from
9408f13 to
344e166
Compare
JacobBarthelmeh
approved these changes
Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check-in FIPS 140-3 PILOT
Testing
Normal build testing. Copied over the updated files from the fips repo.
Checklist