Zd16449 more fixes#6772
Merged
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom Sep 14, 2023
Merged
Conversation
dgarske
previously approved these changes
Sep 13, 2023
Contributor
Author
|
retest this please |
JacobBarthelmeh
approved these changes
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes zd#16449: memory leak issue with args->sigData.
Better to not reallocate the memory which will presumably be the same length and will only lead to possible memory fragmentation. It's also not great to free the memory in case the offloaded asynchronous device is using it.