Enforce WOLFSSL_SP_NO_UMAAL with _CORTEX_M_ASM#6793
Conversation
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Looks good. I'd like @SparkiDev to review also.
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
The UMAAL exists on M4, not M3.
Here is the macro to tell difference:
M3: #define __ARM_ARCH_7M__ 1
M4: #define __ARM_ARCH_7EM__ 1
Perhaps this logic should go into sp.h?
dgarske
force-pushed
the
no_umaal_for_cortexm
branch
from
4a6feb3 to
e73fcc2
Compare
There was a problem hiding this comment.
Should this be:
#if defined(__ARM_ARCH) && (__ARM_ARCH < 8) || defined(ARM_ARCH_7M)
There was a problem hiding this comment.
No, that would disable it for M4. It could be just #if defined(ARM_ARCH_7M).
These are set exclusively (only one or the other) for each platform:
M3: #define __ARM_ARCH_7M__ 1
M4: #define __ARM_ARCH_7EM__ 1
There was a problem hiding this comment.
If you want I could rewrite to:
#if defined(WOLFSSL_SP_ARM_CORTEX_M_ASM) && defined(__ARM_ARCH_7M__)
#undef WOLFSSL_SP_NO_UMAAL
#define WOLFSSL_SP_NO_UMAAL
#endif
There was a problem hiding this comment.
OK make it just ARM_ARCH_7M like in the your last comment.
dgarske
force-pushed
the
no_umaal_for_cortexm
branch
from
e73fcc2 to
347394c
Compare
|
Retest this please |
4 participants
Description
Implicitly add WOLFSSL_SP_NO_UMAAL when WOLFSSL_SP_ARM_CORTEX_M_ASM is enabled
Testing
Tested via wolfBoot build