AES XTS x64 ASM: add AVX1 and AESNI implementations#6815
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Sep 29, 2023
Merged
AES XTS x64 ASM: add AVX1 and AESNI implementations#6815JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
SparkiDev
force-pushed
the
aes_xts_x64
branch
2 times, most recently
from
149b54d to
52fd088
Compare
douzzer
approved these changes
Sep 28, 2023
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
Looks great. Performance is as hoped for:
AES-XTS-enc 5160 MiB took 1.001 seconds, 5155.927 MiB/s Cycles per byte = 0.63
AES-XTS-dec 5160 MiB took 1.001 seconds, 5156.762 MiB/s Cycles per byte = 0.63
and tests good loaded in the kernel, including kernel sanitizer:
[linuxkm-aesni-ksanitize-insmod] [1 of 2] [62481293ae]
autogen.sh 62481293ae... real 0m16.394s user 0m14.380s sys 0m1.151s
configure... real 0m9.814s user 0m4.628s sys 0m6.148s
build...warning: the compiler differs from the one used to build the kernel
The kernel was built by: gcc (Gentoo 11.3.1_p20230427 p9) 11.3.1 20230427
You are using: gcc (Gentoo 12.3.1_p20230825 p2) 12.3.1 20230825
real 0m30.510s user 1m47.309s sys 0m14.381s
dracut... real 0m16.023s user 0m14.206s sys 0m2.123s
boot and insmod with self-test...done.
[ 350.338507] insmod (667) used greatest stack depth: 22312 bytes left
linuxkm-aesni-ksanitize-insmod OK
[linuxkm-mainline-aesni-pie-gcc-latest-insmod] [2 of 2] [62481293ae]
[targeting kernel /usr/src/linux-6.6-rc3]
configure... real 0m10.238s user 0m4.737s sys 0m6.572s
build...warning: the compiler differs from the one used to build the kernel
The kernel was built by: gcc (Gentoo 12.3.1_p20230825 p2) 12.3.1 20230825
You are using: gcc-13 (Gentoo 13.2.1_p20230826 p7) 13.2.1 20230826
real 0m16.002s user 1m1.092s sys 0m12.110s
dracut... real 0m11.856s user 0m9.966s sys 0m2.132s
boot and insmod with self-test...done.
[ 68.798037] insmod (1195) used greatest stack depth: 9944 bytes left
linuxkm-mainline-aesni-pie-gcc-latest-insmod OK
Changes in C files all look good. I ran my eyes over the asm but I'm basing my approval strictly on the automated test results 😉
Contributor
|
Jenkins, retest this please. |
Adding AES-XTS AVX1 and AESNI implementations. Fix name in comment at top of x64 assembly files.
douzzer
force-pushed
the
aes_xts_x64
branch
from
52fd088 to
3ea0fb3
Compare
JacobBarthelmeh
approved these changes
Sep 29, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Nice! Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding AES-XTS AVX1 and AESNI implementations.
Fix name in comment at top of x64 assembly files.
Testing
Tested with and without xts and intelasm.
Checklist