mp_sqrtmod_prime: bail early on the check for small values#6828
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Oct 5, 2023
Merged
mp_sqrtmod_prime: bail early on the check for small values#6828JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
SparkiDev
force-pushed
the
mp_sqrtmod_prime_cust_curve
branch
from
380eabb to
05dfed4
Compare
SparkiDev
changed the title
When using custom curves, only use the first 22 values with the prime to calculate Legendre symbol. The known curves work and defeats long running times when non-prime values are passed in.
SparkiDev
force-pushed
the
mp_sqrtmod_prime_cust_curve
branch
from
05dfed4 to
e55e679
Compare
Contributor
|
retest this please |
JacobBarthelmeh
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using custom curves, only use the first 22 values with the prime to calculate Legendre symbol. The known curves work and defeats long running times when non-prime values are passed in.
Fixes zd#16753
Testing
PoC
Checklist