Skip to content

Fix wc_RsaKeyToDer docs return value#6830

Closed
mspiegel wants to merge 1 commit intowolfSSL:masterfrom
mspiegel:patch-1
Closed

Fix wc_RsaKeyToDer docs return value#6830
mspiegel wants to merge 1 commit intowolfSSL:masterfrom
mspiegel:patch-1

Conversation

@mspiegel
Copy link
Copy Markdown

@mspiegel mspiegel commented Oct 3, 2023

Description

Documentation for wc_RsaKeyToDer() return value is incorrect.

Fixes zd#

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@anhu anhu self-assigned this Oct 3, 2023
@anhu
Copy link
Copy Markdown
Member

anhu commented Oct 3, 2023

hello @mspiegel ,
I've checked and it appears you do not have a signed contributor agreement with wolfSSL. This is a fairly minor contribution and we typically wouldn't take such a small change. Are you planning to add anymore changes?

@mspiegel
Copy link
Copy Markdown
Author

mspiegel commented Oct 3, 2023

I may submit changes in the future, but I don't have any more changes to this pull request regarding documentation. I am available to sign a contributor agreement.

@anhu
Copy link
Copy Markdown
Member

anhu commented Oct 4, 2023

Hi @mspiegel ,

I've spoken with the internal engineering team. Usually when we get smaller minor fixes, we can treat them as suggested bug fixes. This prevents you from going through the trouble of signing a contributor form and having to submit your personal data to us.

This message will now close this PR in favour of #6837 .

Thank you so much for bringing this to our attention!!

Warm regards, Anthony

@anhu anhu closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants