Fix wolfSSL_set_verify_result to use correct value#6847
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Oct 6, 2023
Merged
Fix wolfSSL_set_verify_result to use correct value#6847JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
JacobBarthelmeh
previously approved these changes
Oct 6, 2023
Contributor
|
Please add a simple test case, this could be a 'set' followed right after by a 'get' call and compare. |
JacobBarthelmeh
previously approved these changes
Oct 6, 2023
Member
Author
|
Retest this please Jenkins |
Member
Author
|
retest this please |
JacobBarthelmeh
approved these changes
Oct 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, these two functions are not complimentary:
wolfSSL_get_verify_result()returns the value ofssl->peerVerifyRetwolfSSL_set_verify_result()sets the value ofssl->verifyCallbackResult(
verifyCallbackResultisn't referenced anywhere else in wolfSSL)FIX: these two functions should read/write the same location
Fixes zd16767
Testing
Customer confirmed.
Checklist