wolfio: request only IPv4 addresses unless IPv6 support is enabled#6865
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Oct 13, 2023
Merged
Conversation
|
Can one of the admins verify this patch? |
Member
|
okay to test |
JacobBarthelmeh
approved these changes
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no need to request IPv6 addresses if IPv6 is not enabled - the returned addresses are assumed to be IPv4 ones later in the code. In fact the reverse is true as well - which is NOT a correct assumption as getaddrinfo() can return IPv4 addresses since hints.ai_family = AF_UNSPEC. This is outside of the scope here though as we do not enable IPv6 support for wolfIO.
Testing
Manual tests .
Checklist