ARMv7a SHA256: explicit size on vmov#6878
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Oct 20, 2023
Merged
Conversation
For SHA256 using NEON on ARM32, change vmov instruction that is moving from scalar to general-purpose register to have explicit size (32 bits). May be needed by some compilers.
SparkiDev
force-pushed
the
sha256_armv7a_vmov_fix
branch
from
8606dcd to
4ac7959
Compare
JacobBarthelmeh
approved these changes
Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For SHA256 using NEON on ARM32, change vmov instruction that is moving from scalar to general-purpose register to have explicit size (32 bits). May be needed by some compilers.
Fixes zd#16848
Testing
./configure '--disable-shared' 'LDFLAGS=--static' '--host=armv7a' 'CC=arm-linux-gnueabihf-gcc' '--enable-armasm' '--enable-cryptonly'
Checklist