SM2 named curve disabled: value outside of supported values#6880
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Oct 18, 2023
Merged
SM2 named curve disabled: value outside of supported values#6880JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
JacobBarthelmeh
approved these changes
Oct 17, 2023
JacobBarthelmeh
requested changes
Oct 17, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
the master + openvpn is expected to fail but looks like there is an additional failure reported with the PRB tests that needs investigation before merging:
Requires AEAD
Verified suite validity
Unable to get supported curve
Unsupported cipher suite, ClientHello 1.3
wolfSSL Leaving DoTls13ClientHello, return -421
SparkiDev
force-pushed
the
sm2_named_group_val_fix
branch
from
22f0031 to
1e0cdd1
Compare
SM2 named curve value is specified in specification. Values 0-14 aren't used, so, those bits in disabledCurves are used for values over 31. Add range checks.
SparkiDev
force-pushed
the
sm2_named_group_val_fix
branch
from
1e0cdd1 to
1e84d24
Compare
Contributor
Author
|
retest this please |
JacobBarthelmeh
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SM2 named curve value is specified in specification. Values 0-14 aren't used, so, those bits in disabledCurves are used for values over 31.
Add range checks.
Testing
Standard
Checklist