Fix for pthreads on MSYS2 & MINGW#6881
Merged
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom Oct 17, 2023
Merged
Conversation
dgarske
previously approved these changes
Oct 17, 2023
JacobBarthelmeh
previously approved these changes
Oct 17, 2023
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Passes now with ./autogen.sh && ./configure --host=x86_64-w64-mingw32 && make. Thanks
JacobBarthelmeh
approved these changes
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for pthread issues in #6874 and #6838.
Includes a fix for a truncated output warning. This was resolved by incrementing
MAX_PATHandMAX_FILENAME_SZto260+1as the max value on windows is 260 (https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry)Testing
Reproduced reports on mingw. These changes resolved the problems locally.
Checklist