Add error reporting to loadX509orX509REQFromBuffer#6892
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 22, 2023
Merged
Add error reporting to loadX509orX509REQFromBuffer#6892JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Member
Author
|
retest this please |
Member
|
Please add some tests to make sure the errors stay set in the future. |
julek-wolfssl
approved these changes
Nov 20, 2023
JacobBarthelmeh
approved these changes
Nov 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If there is a failure parsing a certificate from the bio, we should be able to get a reason for the error (either as a return code, or another mechanism such as ERR_get_error).
Fixes #6890
Testing
Customer confirmed
Checklist