Skip to content

Add error reporting to loadX509orX509REQFromBuffer#6892

Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
embhorn:gh6890
Nov 22, 2023
Merged

Add error reporting to loadX509orX509REQFromBuffer#6892
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
embhorn:gh6890

Conversation

@embhorn
Copy link
Copy Markdown
Member

@embhorn embhorn commented Oct 19, 2023

Description

If there is a failure parsing a certificate from the bio, we should be able to get a reason for the error (either as a return code, or another mechanism such as ERR_get_error).

Fixes #6890

Testing

Customer confirmed

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn
Copy link
Copy Markdown
Member Author

embhorn commented Oct 31, 2023

retest this please

@embhorn embhorn marked this pull request as ready for review October 31, 2023 13:22
@embhorn embhorn requested a review from julek-wolfssl October 31, 2023 15:37
@embhorn embhorn assigned julek-wolfssl and unassigned embhorn Oct 31, 2023
@julek-wolfssl
Copy link
Copy Markdown
Member

Please add some tests to make sure the errors stay set in the future.

@julek-wolfssl julek-wolfssl assigned wolfSSL-Bot and unassigned embhorn Nov 20, 2023
@JacobBarthelmeh JacobBarthelmeh merged commit 2f920b5 into wolfSSL:master Nov 22, 2023
@embhorn embhorn deleted the gh6890 branch April 24, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

:[enhancement] PEM_X509_INFO_read_bio doesn't set error when parsing a certificate fails

4 participants