Fixes for PKCS w/out RSA and Cert/CSR signing with unknown OID#6902
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Nov 1, 2023
Merged
Fixes for PKCS w/out RSA and Cert/CSR signing with unknown OID#6902JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
…nature function will add without OID, which is invalid. For example RSA is disabled and CSR tries to use `CTC_SHA256wRSA`. The `wc_SignCert_ex` will succeed and report success, but the CSR/Cert will be invalid (missing sigType OID).
Member
Author
|
Retest this please |
2 similar comments
Member
Author
|
Retest this please |
Member
Author
|
Retest this please |
JacobBarthelmeh
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AddSignaturefunction will add without OID, which is invalid. For example RSA is disabled and CSR tries to useCTC_SHA256wRSA. Thewc_SignCert_exwill succeed and report success, but the CSR/Cert will be invalid (missing sigType OID).Fixes ZD 16675
Testing
Checklist