SP int: don't use sp_digit as the type is sp_int_digit#6917
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 1, 2023
Merged
SP int: don't use sp_digit as the type is sp_int_digit#6917JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Stop casting to the wrong type. SP int code use sp_int_digit and sp_digit can be a different signedness.
SparkiDev
force-pushed
the
sp_int_no_sp_digit
branch
from
6657bdf to
2e37ff4
Compare
JacobBarthelmeh
approved these changes
Nov 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop casting to the wrong type. SP int code use sp_int_digit and sp_digit can be a different signedness.
Testing
Standard tests
Checklist