Can guarantee not to modify arguments of mp_isodd and mp_iszero#6940
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 2, 2023
Merged
Can guarantee not to modify arguments of mp_isodd and mp_iszero#6940JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
mp_isodd and mp_iszero#6940JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
dgarske
requested review from
JacobBarthelmeh
and removed request for
dgarske
dgarske
reviewed
Nov 2, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
What about the other two math implementations?
Contributor
Author
|
Looks like this fixes the issue when running on boz-xeon3. |
Contributor
Author
|
The other two implementations use macros |
SparkiDev
approved these changes
Nov 2, 2023
JacobBarthelmeh
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests fail when using code that passes a const value to a non-const function.