IAR Thumb2 ASM: fixes#6971
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Nov 21, 2023
Merged
Conversation
SparkiDev
force-pushed
the
iar_thumb2_asm
branch
from
312414a to
4e660d4
Compare
Don't assign constants to registers with IAR. Don't assume register usage in AES_set_encrypt_key.
SparkiDev
force-pushed
the
iar_thumb2_asm
branch
4 times, most recently
from
1e6df4d to
51d49d2
Compare
Make a separate AES for IAR that has AES_encrypt_block and AES_decrypt_block inlined. Default code is relying on compiler to use specific registers and not modify others. Improve performance of small SP ASM code for RSA.
SparkiDev
force-pushed
the
iar_thumb2_asm
branch
from
51d49d2 to
9ac3083
Compare
JacobBarthelmeh
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't assign constants to registers with IAR.
Don't assume register usage in AES_set_encrypt_key.
Fixes zd#16991
Testing
./configure '--disable-shared' '--host=armv7m' 'CC=arm-linux-gnueabi-gcc' 'LDFLAGS=--static' '--enable-armasm' '--enable-cryptonly'
Checklist