Memory usage fixes: nonce type and TLSX extension free#7005
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 28, 2023
Merged
Memory usage fixes: nonce type and TLSX extension free#7005JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Nonce ciphers other than AES. Free uses DYNAMIC_TYPE_CIPHER. AES allocation must use DYNAMIC_TYPE_CIPHER too. If not all TLSX extensions can be freed, then free the ones that can. Update TLSX_free() to have a message for each case.
SparkiDev
force-pushed
the
memusage_fix_5
branch
from
000c8b0 to
09d2ba8
Compare
SparkiDev
changed the title
JacobBarthelmeh
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Nonce ciphers other than AES. Free uses DYNAMIC_TYPE_CIPHER.
AES allocation must use DYNAMIC_TYPE_CIPHER too.
If not all TLSX extensions can be freed, then free the ones that can.
Update TLSX_free() to have a message for each case.
Testing
Memusage testing.
Errors reported and now none.
Checklist