Aria sign fix#7082
Merged
douzzer merged 5 commits intowolfSSL:masterfrom Dec 22, 2023
Merged
Conversation
added 4 commits
December 19, 2023 15:33
Used the wrong function to extract key
Don't need to check parameters at every level
Contributor
Author
|
retest this please |
SparkiDev
previously requested changes
Dec 21, 2023
|
|
||
| if (rv == MC_OK) { | ||
| int ret = wc_BuildEccKeyDer(key,keyAsn1,&keyAsn1Sz,0,0); | ||
| int ret = wc_EccPrivateKeyToDer(key,keyarr,keySz); |
|
|
||
| WOLFSSL_ENTER("AriaVerify"); | ||
|
|
||
| *res = 0; /* Default to invalid signature */ |
bandi13
force-pushed
the
ARIA_Sign_fix
branch
from
2a6a93b to
b5592c4
Compare
douzzer
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue when using MagicCrypto's version of signing. Turns out the wrong key format was used.