20240104-with-liboqs-clang-tidy#7114
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jan 5, 2024
Merged
Conversation
* readability-named-parameter (style) * bugprone-sizeof-expression (true bugs) * clang-analyzer-deadcode.DeadStores (true bugs) * clang-analyzer-core.NonNullParamChecker (true bug) * clang-diagnostic-newline-eof (style) * clang-diagnostic-shorten-64-to-32 (true but benign in practice) fixes for sanitizer reported defects --with-liboqs: null pointer memcpy()s in TLSX_KeyShare_GenPqcKey() and server_generate_pqc_ciphertext(). fixes for silent crypto-critical failure in wolfSSL_liboqsGetRandomData(): refactor to accommodate oversize numOfBytes, and abort() if wc_RNG_GenerateBlock() returns failure.
Contributor
Author
|
retest this please. |
dgarske
approved these changes
Jan 5, 2024
Contributor
Author
|
retest this please. |
SparkiDev
previously requested changes
Jan 5, 2024
anhu
requested changes
Jan 5, 2024
anhu
approved these changes
Jan 5, 2024
dgarske
dismissed
SparkiDev’s stale review
Not going to do retry now. Just solving the case where no data was written and silently failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for
clang-tidyreported defects and misstylings--with-liboqs:readability-named-parameter(style)bugprone-sizeof-expression(true bugs)clang-analyzer-deadcode.DeadStores(true bugs)clang-analyzer-core.NonNullParamChecker(true bug)clang-diagnostic-newline-eof(style)clang-diagnostic-shorten-64-to-32(true but benign in practice)fixes for sanitizer reported defects
--with-liboqs: null pointermemcpy()s inTLSX_KeyShare_GenPqcKey()andserver_generate_pqc_ciphertext().fixes for silent crypto-critical failure in
wolfSSL_liboqsGetRandomData(): refactor to accommodate oversizenumOfBytes, andabort()ifwc_RNG_GenerateBlock()returns failure.tested with
wolfssl-multi-test.sh ... check-self check-file-modes check-source-text check-shell-scripts check-configure all-gcc-c99 pq-all pq-all-clang-tidy pq-all-sanitizer pq-all-cppcheck(
pq-all-clang-tidypq-all-sanitizerpq-all-cppcheckare new tests)supersedes fix in #7111 which itself fixed #7108 .