add heap hint support for a few of the x509 functions

[jpbland1]

Description

Adds heap hint support only for the functions the customer asked for

Fixes zd# 17258

Testing

Uses api and crl tests

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[dgarske]

Use str->cm->heap

[jpbland1]

ah ok, str->cm is checkedfor NULL

[dgarske]

Do you really need wolfSSL_X509_dup_ex? Can't the wolfSSL_X509_dup just use x->heap from the previous one? If you have places where heap isn't populated then switch those to using wolfSSL_X509_new_ex.

[jpbland1]

you're right, I had this in my other PR but was following what the customer gave me for this one

[jpbland1]

retest this please

[jpbland1]

I'm getting:

Got -132 but expected -171 at line 4947 in ecdsa_invalid_data_tests
Encountered an unexpected result
 ECDSA-INVALID ... FAILED

which I don' think I've changed, lets try one more time:
retest this please

[dgarske]

@jpbland1 . This is a known issue. @lealem47 is working on it.

[dgarske]

Looks good. Thanks

[lealem47]

Jenkins Retest this please

[dgarske]

Please add a test case for wolfSSL_X509_d2i_ex or adapt an existing one. How have you confirmed all X509 nodes have the heap hint? Did you try with WOLFSSL_HEAP_TEST?

[jpbland1]

Please add a test case for wolfSSL_X509_d2i_ex or adapt an existing one. How have you confirmed all X509 nodes have the heap hint? Did you try with WOLFSSL_HEAP_TEST?

Updated the test cases but the question of how to make sure all X509 nodes have the heap hint is why I didn't want to do a half measure on this but we can't blow up the x509small size. I've updated the functions that already have the heap hint and wouldn't require their own ex function and I guess if a customer needs those functions too we can add them but I think we need a long term solution so x509small doesn't break.

Tested working with WOLFSSL_HEAP_TEST.

Comparing the sizes, configured with ./configure --enable-opensslextra=x509small
On 089468f:

$ size -G /usr/local/lib/libwolfssl.so.42.0.0 
      text       data        bss      total filename
    445915     198363      24200     668478 /usr/local/lib/libwolfssl.so.42.0.0

On current commit:

$ size -G /usr/local/lib/libwolfssl.so.42.0.0 
      text       data        bss      total filename
    445979     198535      24200     668714 /usr/local/lib/libwolfssl.so.42.0.0

A difference of 236 bytes