CRL Monitor Test Fix#7138
Conversation
julek-wolfssl
left a comment
julek-wolfssl
left a comment
There was a problem hiding this comment.
I like the solution, but I would prefer for it to go into a different function than copy_file. This suggests that the file is really copied while link just creates a hard link which is not a real copy. The tests that currently use copy_file can have macros to use the link version of the function when available.
ejohnstown
force-pushed
the
crl-mon-test-fix
branch
from
5da9786 to
53397f9
Compare
I think that will introduce more complexity. There's a note in |
Then change the file name to something more relevant. Like |
Is the 100 ms delay too short? Would increasing that make it stop failing? Increasing the delay would simplify this PR. |
I've bumped it up to 1 second and it still had issues. |
I don't believe that the mac is that slow. Did you make sure to modify the last sleep not the others? |
ejohnstown
force-pushed
the
crl-mon-test-fix
branch
3 times, most recently
from
3fd9b52 to
079838f
Compare
1. For Mach and FreeBsd builds, add the function link_file() which makes a hard link for a file. 2. Add a macro STAGE_FILE that either calls copy_file or link_file depending on doing a Mach or FreeBSD build or not. This is to work around how the CRL Monitor is detecting file changes made by the CRL monitor test in the testsuite. Linux and Windows are detecting the file copies and deletes, and how macOS detects them. kevent sees the link as a single change to the parent directory and reads it. When you copy the file, kevent sees the new file getting opened and triggering the file update.
ejohnstown
force-pushed
the
crl-mon-test-fix
branch
from
079838f to
b66a108
Compare
4 participants
Description
Changed the CRL Monitor test so that it uses the macro STAGE_FILE to stage the CRL files for its test cases. That macro will be copy_file() in most builds. In macOS builds (Mach or FreeBSD), STAGE_FILE will be link_file() which makes a hard link of the CRL file instead of a copy. On the Mac, intermittently, the copy_file() will trigger a CRL monitor update when the file is first opened, not when the copy is complete. link() is atomic.
Testing
Running on a macMini M1, I would get intermittent failures in the testsuite. Just ran it
./configure --enable-all, or./configure --enable-crl --enable-crl-monitor. I'd just run the testsuite a few times.Checklist