Skip to content

20240119-DoTls13CertificateVerify-CreateSigData-error-handling#7145

Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom
douzzer:20240119-DoTls13CertificateVerify-CreateSigData-error-handling
Jan 21, 2024
Merged

20240119-DoTls13CertificateVerify-CreateSigData-error-handling#7145
SparkiDev merged 1 commit intowolfSSL:masterfrom
douzzer:20240119-DoTls13CertificateVerify-CreateSigData-error-handling

Conversation

@douzzer
Copy link
Copy Markdown
Contributor

@douzzer douzzer commented Jan 19, 2024

src/tls13.c: in DoTls13CertificateVerify(), add missing error handling in several calls to CreateSigData().

tested with ../testing/git-hooks/wolfssl-multi-test.sh --enable-bwrap --enable-git-blame -j 24 --keep-going --max-check-try-count=3 --no-result-cache --verbose-analyzers --test-uncommitted --verbose-qemu-system pq-all-clang-tidy

problem report from nightly:

[pq-all-clang-tidy] [54 of 216] [ac81d9d29c]
    configure...   real 0m19.953s  user 0m10.616s  sys 0m10.792s
    build...9be390250d (<anhu@users.noreply.github.com> 2024-01-18 16:20:57 -0500 9925)                     args->sigDataSz = sigDataSz;
/home/wolfbot/tmp/wolfssl_test_workdir.56048/wolfssl/src/tls13.c:9925:37: warning: Assigned value is garbage or undefined [clang-analyzer-core.uninitialized.Assign]
9925 |                     args->sigDataSz = sigDataSz;
|                                     ^ ~~~~~~~~~
[...]

Copy link
Copy Markdown
Member

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @douzzer . Over to @SparkiDev for final

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Jan 19, 2024

Retest this please

@SparkiDev SparkiDev removed the request for review from wolfSSL-Bot January 21, 2024 21:36
@SparkiDev SparkiDev merged commit d2d653c into wolfSSL:master Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants