Update IAR-EWARM project user-settings.h.#7195
Conversation
There was a problem hiding this comment.
FYI: This was likely using integer.c heap math previously. Not fast math. I'd recommend providing a template here for users to choose 4 options. Use something like this: https://github.com/wolfSSL/wolfssl/blob/master/examples/configs/user_settings_template.h#L62
|
Retest this please |
There was a problem hiding this comment.
Please expand the comment here. The SP section can exist on its own outside of these 3 options.
Our Single Precision math written to acceleration specific / common key sizes and curves. This adds code from sp_c32.c or one of the specific assembly ones like sp_cortexm.c. This code is faster than the multi-precision support because its optimized for the key/curve.
The SP math can be used together with any multi-precision math library if WOLFSSL_SP_MATH is removed. If only standard keys/curves are being used the multi-precision math is not required.
There was a problem hiding this comment.
To try to make it more clear, I ordered it like this:
- Single Precision math example first, along with expanded comments.
- Followed by SP Math All, and expanded comments to mention this uses multi-precision math library.
- Fast math example.
- Normal integer.c math example.
| * | ||
| * See examples/configs/user_settings_template.h for a more | ||
| * detailed template. */ | ||
| #if 1 |
There was a problem hiding this comment.
This section for single precision can exist all on its own. It can be used regardless of the 3 multi-precision math library options as long as WOLFSSL_SP_MATH is not defined.
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Accepting as-is. I will put up similar PR in the user_settings_template.h and fix the SP toggle.
|
Retest this please |
3 participants
Description
The
IAR-EWARM/Projects/user_settings.hwas outdated and assumed fast-math by default. This resulted in many build errors when building IAR-EWARM wolfssl-lib.a.Update the user_settings.h to use SP Math All.
Fixes zd#17406
Testing
Built wolfssl lib with IAR ARM IDE on windows.