Thumbs inline ASM IAR: fix register clobber list#7221
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 7, 2024
Merged
Conversation
Change register clobber list so that it reserves the same registers for constants regardless of WOLFSSL_NO_VAR_ASSIGN_REG.
josepho0918
suggested changes
Feb 7, 2024
Contributor
josepho0918
left a comment
josepho0918
left a comment
There was a problem hiding this comment.
The unnecessary alignment XALIGNED(16) can be removed from AES and SHA tables.
dgarske
approved these changes
Feb 7, 2024
Contributor
Author
|
I'll leave the alignment to potentially make it quicker to read the tables as there will definitely be no alignment issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change register clobber list so that it reserves the same registers for constants regardless of WOLFSSL_NO_VAR_ASSIGN_REG.
Fixes zd#17225
Testing
./configure '--disable-shared' '--host=armv7m' 'CC=arm-linux-gnueabi-gcc' 'LDFLAGS=--static' '--enable-armasm=inline' 'CFLAGS=-DWOLFSSL_NO_VAR_ASSIGN_REG'
And with IAR Workbench.
Checklist