tls13: wolfSSL_read_early_data() set outSz to 0 if no early data and update doc#7222
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Feb 12, 2024
Merged
tls13: wolfSSL_read_early_data() set outSz to 0 if no early data and update doc#7222dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
julek-wolfssl
requested changes
Feb 7, 2024
Member
There was a problem hiding this comment.
Maybe it would be better to do this at the very beginning of the function in all cases?
Contributor
Author
There was a problem hiding this comment.
My rationale was that if the function errors out then it doesn't change the parameter.
But I'm ok moving that at the beginning as well.
rizlik
force-pushed
the
early_data_fix
branch
from
72f094e to
c3ed708
Compare
If not data is read, set outSz to 0. This way the caller can detect if no early data was read.
rizlik
force-pushed
the
early_data_fix
branch
from
c3ed708 to
7b0fefb
Compare
julek-wolfssl
approved these changes
Feb 12, 2024
dgarske
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The function has a different return behavior compared to the doc. It also fails to set outSz to zero if no early data are received. Fixed and updated the doc.