Add wolfSSL debug messages#7223
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Feb 11, 2024
Merged
Conversation
12a68ec to
8522119
Compare
SparkiDev
requested changes
Feb 8, 2024
Contributor
|
Don't want the debug to become too noisy. |
3a1df26 to
4dcdcd0
Compare
4dcdcd0 to
bf29066
Compare
Contributor
Author
Agreed. I removed some of the messages that were only breadcrumbs without any real value. I hadn't intended this to be such a big code review, but I appreciate your time. I hope this update addresses all of your suggestions. All were completely valid. Thank you. |
SparkiDev
approved these changes
Feb 11, 2024
Contributor
|
Thanks for all the changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR adds debug messages in various functions, mostly surrounding more informative failures.
I found these useful while troubleshooting memory-constrained devices. It's particularly helpful to see the sizes of heap allocation attempts.
Of particular interest is wolfSSL_new
XMALLOCand the subsequent check ofInitSSL()for positive return values. I didn't actually see any. They probably don't even occur. Still...There's otherwise some tidying up and other minor changes.
Fixes zd# n/a
Testing
How did you test?
Tested in Espressif environment and
I did see a failure for this:
But the exact same failure also occurs with a fresh clone of wolfssl.
Checklist