Decode OCSP Revocation Reason#7241
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 12, 2024
Merged
Conversation
1. The ASN.1 parser wasn't handling the OCSP response correctly when there was a revocation reason included in the response. The encoded reason value is constructed, and was getting marked as not constructed in the parser. Changed the flag to mark it as constructed.
Contributor
Author
|
retest this please |
dgarske
approved these changes
Feb 12, 2024
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Would really like a test case that covers this but I understand that is difficult
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ASN.1 parser wasn't handling the OCSP response correctly when there was a revocation reason included in the response. The encoded reason value is constructed, and was getting marked as not constructed in the parser. Changed the flag to mark it as constructed.
(Fixes ZD 17027)
Testing
I have a set of certificates I've been using for some testing. I added one for a server and use it with an OCSP lookup. I have two alternate certificate lists where this certificate is revoked: one without a revocation reason and one with the optional reason. Both should report the certificate as revoked. (The original report was that the lookup failed.)
Checklist