Skip to content

Add const in the list of wolfSSL_CTX_set1_groups_list() and wolfSSL_set1_groups_list()#7260

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
kosmas-valianos:missingConst
Feb 28, 2024
Merged

Add const in the list of wolfSSL_CTX_set1_groups_list() and wolfSSL_set1_groups_list()#7260
douzzer merged 1 commit intowolfSSL:masterfrom
kosmas-valianos:missingConst

Conversation

@kosmas-valianos
Copy link
Copy Markdown
Contributor

Description

wolfSSL_CTX_set1_groups_list() and wolfSSL_set1_groups_list() were not using const for the list parameter like wolfSSL_CTX_set1_sigalgs_list() and wolfSSL_set1_sigalgs_list() do.

Testing

Passing a const char* shall work now like it works for SSL_CTX_set1_sigalgs_list()

const char *tls_sig_algs = "RSA-PSS+SHA512:RSA-PSS+SHA384:RSA+SHA512:RSA+SHA384:ECDSA+SHA512:ECDSA+SHA384";
if ((wolfssl_ret = SSL_CTX_set1_sigalgs_list(vpn_ctx->ssl_ctx, tls_sig_algs)) != SSL_SUCCESS)
{
...
}

const char *tls_groups = "P-521:P-384:P-256";
if ((wolfssl_ret = wolfSSL_CTX_set1_groups_list(vpn_ctx->ssl_ctx, tls_groups)) != SSL_SUCCESS)
{
...
}

…et1_groups_list()

aligning with the wolfSSL_CTX_set1_sigalgs_list()/wolfSSL_set1_sigalgs_list() API
@wolfSSL-Bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Feb 28, 2024

ok to test

@douzzer
Copy link
Copy Markdown
Contributor

douzzer commented Feb 28, 2024

retest this please

@douzzer douzzer merged commit daf43cd into wolfSSL:master Feb 28, 2024
@kosmas-valianos kosmas-valianos deleted the missingConst branch February 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants