Fixes for benchmark with small stack (RSA was being skipped)#7268
Merged
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom Feb 23, 2024
Merged
Fixes for benchmark with small stack (RSA was being skipped)#7268JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom
Conversation
…humb2 benchmarks for STM32H753.
* remove redundant nullness checks covered by WC_ALLOC_VAR() via WC_ALLOC_DO_ON_FAILURE(); * add "exit:" logic to bench_sm4_gcm(); * add missing WC_ALLOC_VAR() in bench_sm4_ccm(); * fix early return in bench_ed448KeySign().
Contributor
|
retest this please |
dgarske
commented
Feb 23, 2024
Member
Author
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Approved. Over to PR cap.
JacobBarthelmeh
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for benchmark with small stack (RSA was being skipped). Added Thumb2 benchmarks for STM32H753.
Fixes ZD 17565.
Testing
Checklist