fixed XMALLOC, XFREE and XREALLOC definitions for embOS#7274
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Feb 27, 2024
Merged
fixed XMALLOC, XFREE and XREALLOC definitions for embOS#7274douzzer merged 2 commits intowolfSSL:masterfrom
douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
|
Can one of the admins verify this patch? |
anhu
reviewed
Feb 27, 2024
| #define XFREE(p, h, type) ((void)(h), (void)(type), OS_HEAP_free((p))) | ||
| #define XREALLOC(p, n, h, t) ((void)(h), (void)(t), OS_HEAP_realloc(((p), (n))) | ||
| /* Per the user manual of embOS https://www.segger.com/downloads/embos/UM01001 | ||
| this API has changed with V5. */ |
Member
There was a problem hiding this comment.
Our style is to prefix this line with * so that "this" will align with "Per" on the line above.
| #endif | ||
| #define XREALLOC(p, n, h, t) wolfSSL_Realloc((p), (n), (h), (t)) | ||
| #endif /* WOLFSSL_DEBUG_MEMORY */ | ||
| #elif defined(WOLFSSL_EMBOS) && !defined(XMALLOC_USER) && !defined(NO_WOLFSSL_MEMORY) && !defined(WOLFSSL_STATIC_MEMORY) |
Member
There was a problem hiding this comment.
Our style is to have 80 characters per line. even though this isn't followed in the code surrounding this change (ie XFREE above), but that is for readability. Please use \ to keep lines below 80 characters.
Member
|
Contributor agreement is on file. Assigning to @douzzer for further review. |
douzzer
approved these changes
Feb 27, 2024
Contributor
|
ok to test |
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mismatched parentheses and fix for embOS API v5.
Fixes zd#17586
Testing
How did you test?
Checklist