Merged
Conversation
When PQC Kyber support is enabled, incoming KeyShare messages are tested regarding the named group is a PQC Kyber group (pure or hybrid). The boundaries of this test are way too loose (large gap between the pure ones and the hybrid ones). This could result in failing handshakes in case a client uses GREASE (Generate Random Extensions And Sustain Extensibility), as there group numbers in the large gap are used. The fix is just to make sure that the PQC test uses the two small boundaries of the PQC named groups. The lower bound for the hybrid groups has also been updated to reflect the current OQS definition. Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
|
Can one of the admins verify this patch? |
Member
|
Ah, yes, the boundaries were too wide because we use to support other hybrid KEMs. This was a left over artifact of older code. |
Member
|
Okay to test |
anhu
approved these changes
Feb 28, 2024
Member
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
dgarske
approved these changes
Mar 8, 2024
Member
|
Retest this please. |
Member
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
When PQC Kyber support is enabled, incoming KeyShare messages are tested regarding the named group is a PQC Kyber group (pure or hybrid). The boundaries of this test are far too loose (large gap between the pure ones and the hybrid ones). This could result in failing handshakes in case a client uses GREASE (Generate Random Extensions And Sustain Extensibility), as with that, group numbers in the large gap are used.
The fix is just to make sure that the PQC test uses the two small boundaries of the PQC named groups.
The lower bound for the hybrid groups has also been updated to reflect the current OQS definition.