Skip to content

Thumb2 AES GCM support for GCM_SMALL#7291

Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:armasm_thumb_gcmsmall
Mar 4, 2024
Merged

Thumb2 AES GCM support for GCM_SMALL#7291
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:armasm_thumb_gcmsmall

Conversation

@dgarske
Copy link
Copy Markdown
Member

@dgarske dgarske commented Mar 1, 2024

Description

Thumb2 AES GCM support for GCM_SMALL. In order to support backwards compatibility with the struct Aes and struct Gcm sizes GCM_SMALL is required.

Fixes ZD 17225

Testing

IAR EW ARM project with simulator and these settings:

#define HAVE_AESGCM
#define GCM_SMALL
#define WOLFSSL_ARMASM
#define WOLFSSL_ARMASM_INLINE
#define WOLFSSL_ARMASM_NO_HW_CRYPTO
#define WOLFSSL_ARMASM_NO_NEON

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Mar 1, 2024
@dgarske dgarske requested a review from SparkiDev March 1, 2024 19:49
@dgarske
Copy link
Copy Markdown
Member Author

dgarske commented Mar 1, 2024

@SparkiDev would love you feedback on this solution. Let's wait to merge until feedback from customer.

Copy link
Copy Markdown
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@dgarske dgarske assigned SparkiDev and wolfSSL-Bot and unassigned dgarske and SparkiDev Mar 4, 2024
@SparkiDev SparkiDev merged commit ee3aff1 into wolfSSL:master Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants