20240301-linuxkm-leak-and-small-stack-fixes#7293
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Mar 4, 2024
Merged
Conversation
* fix WC_LINUXKM_ROUND_UP_P_OF_2() to not round up values that are already powers of 2, nor values larger than 8192. linuxkm/lkcapi_glue.c: * fix gating on km_AesSetKeyCommon(). * small stack refactors of Aes objects in self-test routines. * change kmalloc/free to malloc/free in self-test routines. * fix error-path "return"s to "goto exit"s in self-test routines. * fix memory leak around large_input in aes_xts_128_test(). wolfcrypt/benchmark/benchmark.c: * smallstack refactors in bench_chacha() and bench_chacha20_poly1305_aead(). * add error handling in bench_chacha(). wolfcrypt/src/chacha20_poly1305.c: smallstack refactor for wc_ChaCha20Poly1305_Encrypt() and wc_ChaCha20Poly1305_Decrypt().
ejohnstown
approved these changes
Mar 2, 2024
dgarske
approved these changes
Mar 4, 2024
SparkiDev
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linuxkm/linuxkm_wc_port.h:WC_LINUXKM_ROUND_UP_P_OF_2()to not round up values that are already powers of 2, nor values larger than 8192.linuxkm/lkcapi_glue.c:km_AesSetKeyCommon().Aesobjects in self-test routines.kmalloc/kfreetomalloc/freein self-test routines.returns togoto exits in self-test routines.large_inputinaes_xts_128_test().wolfcrypt/benchmark/benchmark.c:bench_chacha()andbench_chacha20_poly1305_aead().bench_chacha().wolfcrypt/src/chacha20_poly1305.c: smallstack refactor forwc_ChaCha20Poly1305_Encrypt()andwc_ChaCha20Poly1305_Decrypt().tested with
wolfssl-multi-test.sh ... super-quick-check '.*kmemleak.*'bringing in new testslinuxkm-noasm-insmod-kmemleak,linuxkm-aesni-insmod-kmemleak, andlinuxkm-benchmarks-insmod-kmemleak.