MacOS X Intel ASM clang 15: fix asm to compile without warning#7334
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Mar 14, 2024
Merged
MacOS X Intel ASM clang 15: fix asm to compile without warning#7334dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
Don't use align when __APPLE__ is defined. Make minimum alignment on variables in ASM 8 bytes (.p2align 3). Fix x86 builds with ASM.
dgarske
approved these changes
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't use align when APPLE is defined.
Make minimum alignment on variables in ASM 8 bytes (.p2align 3).
Fix x86 builds with ASM.
Fixes #7311
Testing
Built x86 on Linux.
Couldn't test x86_64 MacOS X
Checklist