SHA256 ARMv8: fix wc_Sha256Transform#7338
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 14, 2024
Merged
Conversation
wc_Sha256Transform() was passing in data to underlying transform function even though byte reversed data was in sha256->buffer.
Contributor
Author
|
retest this please |
douzzer
approved these changes
Mar 14, 2024
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
tests good -- passes wolfssl-multi-test.sh ... cross-aarch64-all-armasm-unittest-sanitizer cross-aarch64-armasm-fips-140-3-dev-all-unittest-sanitizer.
Contributor
|
note, merged with failing CI tests because github CI is currently broken (toolchain pain, nginx/krb5/openvpn tests all failing, likely related to sanitizers on gcc-12 as updated by Ubuntu). also, this PR touches only one file, and no CI tests other than the multi-test PRB currently test that one file (which we tested offline), so CI is irrelevant here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_Sha256Transform() was passing in data to underlying transform function even though byte reversed data was in sha256->buffer.
Testing
./configure '--disable-shared' 'LDFLAGS=--static' '--host=aarch64' 'CC=aarch64-linux-gnu-gcc' '--enable-opensslextra' '--enable-armasm'
./tests/unit.test -test_wolfSSL_SHA256_Transform
Checklist