wc_ecc_cmp_param cleanup#7365
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 29, 2024
Merged
Conversation
also return -1 on param mismatch.
danielinux
approved these changes
Mar 28, 2024
douzzer
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
XSTRNCMPreturns 0 (equality) also if param matches onlyparamSzcharacters ofcurveParam. Eg: a comparison withparamSz == 0will always return equality.Another side note is that the function returns -1 for inequality when using
WC_TYPE_UNSIGNED_BIN, but it uses the return ofXSTRNCMPdirectly when usingWC_TYPE_HEX_STR.This PR fixes both.