20240327-tls-int-overflows#7371
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Mar 29, 2024
Merged
Conversation
SparkiDev
previously requested changes
Mar 28, 2024
dgarske
requested changes
Mar 28, 2024
Member
There was a problem hiding this comment.
This logic is incredibly difficult to read and seems to make some assumption about overflow and size_t, which can be 32-bit or 64-bit depending on the platform. Please re-write this and avoid using size_t.
douzzer
force-pushed
the
20240327-tls-int-overflows
branch
from
74d6808 to
beb6748
Compare
dgarske
requested changes
Mar 29, 2024
Member
There was a problem hiding this comment.
c:\jenkins\workspace\prb-windows-test-v2\src\internal.c(10583): warning C4701: potentially uninitialized local variable 'newSz' used [C:\jenkins\workspace\PRB-windows-test-v2\wolfssl.vcxproj] Lib
Contributor
Author
There was a problem hiding this comment.
good catch! it's a false positive, but we don't want any positives, false or otherwise.
I'll tweak the macro.
src/internal.c: mitigations for potential integer overflows in figuring allocation sizes.
douzzer
force-pushed
the
20240327-tls-int-overflows
branch
from
beb6748 to
038be95
Compare
dgarske
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/internal.c: mitigations for potential integer overflows in figuring allocation sizes.tested with
wolfssl-multi-test.sh ... super-quick-checksee ZD#17733