Fix build error with RECORD_SIZE defined#7383
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Apr 2, 2024
Merged
Conversation
Member
Author
|
retest this please |
dgarske
requested changes
Apr 2, 2024
Member
There was a problem hiding this comment.
Should this go near #ifdef RECORD_SIZE at line 2276? Making this a macro is fine with me. I don't see any downstream issues.
dgarske
approved these changes
Apr 2, 2024
JacobBarthelmeh
approved these changes
Apr 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MAX_RECORD_SIZEis defined in an enum, which would have a value of 0 during preprocessing. So ifRECORD_SIZEis user defined, then the checkRECORD_SIZE > MAX_RECORD_SIZEproduces errors:Fixes zd17763
Testing
./configure CFLAGS="-DRECORD_SIZE=1024" && makeChecklist