20240416-fips-v6-fixes#7434
Merged
JacobBarthelmeh merged 6 commits intowolfSSL:masterfrom Apr 17, 2024
Merged
Conversation
…ED448 requires SHAKE256").
…SGCM_STREAM for SAVE_VECTOR_REGISTERS, due to random failures seen with DEBUG_VECTOR_REGISTER_ACCESS_FUZZING using the old per-call fallback strategy.
…le-32bit, fix inconsistency whereby SHAKE was enabled but SHA512 and SHA3 weren't; remove unneeded+unwanted ENABLED_32BIT conditional force-off of SHA512, SHA384, SHA3, ED25519 (harmonizes with FIPS v6).
…erRedundantCheck in src/ssl_load.c (true positive).
JacobBarthelmeh
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for
--enable-32bit CFLAGS=-m32 --enable-fips=v6(fixes "#error ED448 requires SHAKE256").(includes fixes for a fair number of casting flubs detected by
-Wconversiontests.)also, in
configure.acsetup for enable-all and enable-all-crypto with enable-32bit, fix inconsistency whereby SHAKE was enabled but SHA512 and SHA3 weren't; remove unneeded+unwantedENABLED_32BITconditional force-off of SHA512, SHA384, SHA3, ED25519 (harmonizes with FIPS v6).tested with
wolfssl-multi-test.sh ... super-quick-check '.*m32.*'(
.*m32.*matchesdefaults-cryptonly-Wconversion-noasm-fips-140-3-dev-m32-build defaults-cryptonly-Wconversion-noasm-fips-140-3-v6-m32-build defaults-cryptonly-c99-Wconversion-m32-build allcryptonly-c99-Wconversion-m32-build defaults-cryptonly-c89-Wconversion-m32-build allcryptonly-c89-Wconversion-m32-build all-sp-m32 all-crypto-sp-m32.)also several related and minor fixes necessary to get
super-quick-checkto pass locally:wolfcrypt/src/fe_448.c: fix several out-of-order declarations infe448_mul_8().wolfcrypt/src/aes.c: in AES-XTS AESNI, use cautious strategy as in AESGCM_STREAM forSAVE_VECTOR_REGISTERS, due to random failures seen withDEBUG_VECTOR_REGISTER_ACCESS_FUZZINGusing the old per-call fallback strategy.(tested with
wolfssl-multi-test.sh ... linuxkm-legacy-.\*, and a loop for a couple hours onlinuxkm-aesxts-cryptonly-aesni-fips-dev-dyn-hash-LKCAPI-no-twc-insmod-6.1.73-fortify-fallback-fuzzing linuxkm-all-cryptonly-aesni-fips-dev-dyn-hash-LKCAPI-insmod-6.1.73-fortify-fallback-fuzzing linuxkm-all-cryptonly-aesni-fips-dev-dyn-hash-LKCAPI-insmod-mainline-fallback-fuzzing.)scripts/aria-cmake-build-test.sh: fix masked exit value.