Update benchmark to only parse rsa size if keygen is enabled#7471
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Apr 25, 2024
Merged
Conversation
…keygen option help in configure.ac
SparkiDev
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark.c currently parses "-rsa-sz" argument at all times, despite the fact that it relies on non-default RSA keygen code to run the test. Only list and parse the option if WOLFSSL_KEY_GEN is defined. Also update the configure.ac help output to specify that the --enable-keygen option only applies to RSA key generation.