Remove DES3 flag guard from pkcs12 tests#7472
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Apr 29, 2024
Merged
Conversation
Contributor
Author
|
retest |
Member
|
Retest this please |
1 similar comment
Contributor
Author
|
Retest this please |
SparkiDev
approved these changes
Apr 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PKCS12 code in included in the default build, however the code in api.c that tests it is guarded by !defined(NO_DES3), and DES3 is not included in the default build. The PKCS12 test code itself as is does not actually perform any DES3 operations, so can run fine as is in the default build. If the core code is included in the default build, I believe the tests for that code should also be included.