20240606-clang-tidy-and-mingw-fixes#7627
Merged
SparkiDev merged 3 commits intowolfSSL:masterfrom Jun 7, 2024
Merged
Conversation
dgarske
previously approved these changes
Jun 6, 2024
* in wc_port.h, add XWRITE and XREAD definitions and include <io.h>; * in wolfSSL_BIO_read(), implement Windows support for XREAD and XWRITE; * in wolfSSL_BIO_write_filename(), add 'b' flag to XFOPEN flags; * in wolfSSL_RAND_file_name(), add support for XALTHOMEVARNAME, and add Windows definition for it to wc_port.h alongside XWRITE and XREAD. fixes test_wolfSSL_BIO, test_wolfSSL_X509_print, test_wolfSSL_RAND, test_wolfSSL_RSA_print in cross-mingw-all-crypto scenario.
douzzer
force-pushed
the
20240606-clang-tidy-and-mingw-fixes
branch
from
714314f to
ac5caba
Compare
SparkiDev
approved these changes
Jun 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for
USE_WINDOWS_API:XWRITEandXREADdefinitions towc_port.h;wolfSSL_BIO_read(), implement Windows support forXREADandXWRITE;wolfSSL_BIO_write_filename(), add 'b' flag toXFOPENflags;wolfSSL_RAND_file_name(), add support forXALTHOMEVARNAME, and add Windows definition for it towc_port.halongsideXWRITEandXREAD.fixes
test_wolfSSL_BIO,test_wolfSSL_X509_print,test_wolfSSL_RAND,test_wolfSSL_RSA_printincross-mingw-all-cryptoscenario.miscellaneous fixes to clear
wolfssl-multi-test.sh ... super-quick-check:wolfcrypt/src/wc_kyber_poly.c: fixbugprone-macro-parenthesesforFROM_MSG_BIT.wolfcrypt/src/port/riscv/riscv-64-aes.c: fix trailing whitespace.tested with
wolfssl-multi-test.sh ... super-quick-check, which includescross-mingw-all-crypto, locally fixed to work right, i.e. to actually test--enable-all-crypto.