Force inline ASM for armv7 with FIPS#7637
Merged
kaleb-himes merged 1 commit intowolfSSL:masterfrom Jun 12, 2024
Merged
Conversation
kaleb-himes
approved these changes
Jun 11, 2024
Contributor
There was a problem hiding this comment.
Stemming from the ARMv7 unstable hash investigation, use only inline assembly with FIPS module as it is not subject to a run-time load change that can lead to an unstable integrity check. Inline ASM is stable and integrity check holds with the inline assembly on chips supporting Neon instructions.
Great changes @lealem47 thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--enable-armasm. (Sean suspects some assembly code, maybe AES, is using a fixed address, instead of relative, for a table that changes depending on where the code is loaded.)armv7lasarmv7aTesting
Tested on armv7a hardware
Checklist