ret will be set to 1 (WOLFSSL_SUCCESS), the rest checks for 'ret == 0'#7678
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Jun 25, 2024
Merged
ret will be set to 1 (WOLFSSL_SUCCESS), the rest checks for 'ret == 0'#7678JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
Need to use another type of return code
JacobBarthelmeh
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to use another type of return code
This came up as an issue uncovered with our TLSFuzzer. A piece of code was fixed that wasn't checking if
ret != 0and set it to something else. Then subsequent code would work correctly because nowret == 0. When that code was fixed, this issue popped up where the cipher suite was being returned as TLS_NULL_WITH_NULL_NULL.