fix for casting with add#7790
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jul 25, 2024
Merged
Conversation
Contributor
Author
|
retest this please Jenkins |
dgarske
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler for PIC18F treated this as adding two byte types (throwing out the overflow) and then casting it to a word16 type. i.e 0xFF + 0x01 = 0x00 (where 0x100 gets thrown out) and then casted 0x00 to word16 type. Casting each to word16 first and then adding avoids this.