Skip to content

Fix for SP small calling label with GCC#7843

Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:fix_sp_small_gcc
Aug 6, 2024
Merged

Fix for SP small calling label with GCC#7843
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:fix_sp_small_gcc

Conversation

@dgarske
Copy link
Copy Markdown
Member

@dgarske dgarske commented Aug 6, 2024

Description

Fix for SP small calling label with GCC (broken in PR #7753).

Testing

GCC with WOLFSSL_SP_SMALL and WOLFSSL_SP_ARM_CORTEX_M_ASM

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske
Copy link
Copy Markdown
Member Author

dgarske commented Aug 6, 2024

Retest this please:

../testing/Jenkins/generic-config-parser/generic-config-parser.sh -s 100 -c 5 ../testing/Jenkins/generic-config-parser/config-flags/PRB-single-flag.txt
Running 5 tests starting from 100 where USE_FSANITIZE=0 and WOLFSSL_OPENSSL_TEST=1

FAIL: scripts/openssl.test

---
client failed! Suite = DHE-RSA-AES128-SHA256 version = 3
in cleanup
killing server: OpenSSL_RSA (60483)
killing server: wolfSSL_RSA (52827)
killing server: OpenSSL_ECDH[E]-ECDSA (62594)
killing server: wolfSSL_ECDH[E]-ECDSA (52827)
killing server: OpenSSL_TLSv1.3_PSK (49982)
killing server: wolfSSL_TLSv1.3_PSK (57301)
FAIL scripts/openssl.test (exit status: 1)
<<<
Error: Test runtime=99sec. Make Check RESULT = 2
Exiting with status: 1
Script ran for 184 seconds.
script returned exit code 1

Copy link
Copy Markdown
Contributor

@night1rider night1rider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses and fixes the errors I was having with the macros:
WOLFSSL_SP_SMALL and WOLFSSL_SP_ARM_CORTEX_M_ASM when combined

The errors this PR fixed for me:

/home/dell5060/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/dell5060/wolfWork/port/MAX32666/build/sp_cortexm.o: in function `L_sp_2048_cmp_32_words_397':
sp_cortexm.c:(.text.sp_2048_cmp_32+0x34): undefined reference to `L_sp_2048_cmp_32_words'
/home/dell5060/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/dell5060/wolfWork/port/MAX32666/build/sp_cortexm.o: in function `L_sp_2048_cmp_64_words_520':
sp_cortexm.c:(.text.sp_2048_cmp_64+0x34): undefined reference to `L_sp_2048_cmp_64_words'
/home/dell5060/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/dell5060/wolfWork/port/MAX32666/build/sp_cortexm.o: in function `L_sp_3072_cmp_48_words_935':
sp_cortexm.c:(.text.sp_3072_cmp_48+0x34): undefined reference to `L_sp_3072_cmp_48_words'
/home/dell5060/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/dell5060/wolfWork/port/MAX32666/build/sp_cortexm.o: in function `L_sp_3072_cmp_96_words_1058':
sp_cortexm.c:(.text.sp_3072_cmp_96+0x34): undefined reference to `L_sp_3072_cmp_96_words'
/home/dell5060/MaximSDK/Tools/GNUTools/10.3/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: /home/dell5060/wolfWork/port/MAX32666/build/sp_cortexm.o: in function `L_sp_256_cmp_8_words_1177':
sp_cortexm.c:(.text.sp_256_cmp_8+0x34): undefined reference to `L_sp_256_cmp_8_words'
collect2: error: ld returned 1 exit status
make: *** [/home/dell5060/MaximSDK/Libraries/CMSIS/Device/Maxim/GCC/gcc.mk:503: /home/dell5060/wolfWork/port/MAX32666/build/MAX32666.elf] Error 1

@SparkiDev SparkiDev merged commit 18aa2b8 into wolfSSL:master Aug 6, 2024
@dgarske dgarske deleted the fix_sp_small_gcc branch August 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants