Skip to content

Fix interim return variable name when DH enabled#7864

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
gojimmypi:pr-fix-dh-ret
Aug 15, 2024
Merged

Fix interim return variable name when DH enabled#7864
douzzer merged 1 commit intowolfSSL:masterfrom
gojimmypi:pr-fix-dh-ret

Conversation

@gojimmypi
Copy link
Copy Markdown
Contributor

Description

Please describe the scope of the fix or feature addition.

When using a user_settings.h such as this one that turns on DH with #define HAVE_DH, the Espressif TLS Client example currently fails to compile.

.../IDE/Espressif/ESP-IDF/examples/wolfssl_client/main/client-tls.c:300:5: error: 'ret' undeclared (first use in this function)
  300 |     ret = wolfSSL_CTX_SetMinDhKey_Sz(ctx, (word16)minDhKeyBits);
      |     ^~~

The example otherwise works with the user_settings.h that it has.

This is related to coming up with a common user_settings.h in the template example that will be copied to the published Espressif wolfSSL Managed Component.

I do have major updates to the Espressif examples and cmake files, not ready for PR.

Fixes zd# n/a

Testing

How did you test?

Tested only on Espressif platform.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi gojimmypi requested a review from dgarske August 13, 2024 16:23
@gojimmypi gojimmypi self-assigned this Aug 13, 2024
@dgarske dgarske requested a review from douzzer August 13, 2024 16:39
@douzzer douzzer merged commit 0c24aff into wolfSSL:master Aug 15, 2024
@gojimmypi gojimmypi deleted the pr-fix-dh-ret branch October 9, 2024 18:08
@gojimmypi gojimmypi changed the title fix interim return variable name when DH enabled Fix interim return variable name when DH enabled Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants